feat: Abort early in delete_eni.py lambda for privatelink-access #2153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denys Havrysh <[email protected]>
Author
|
Hi @askulkarni2 , could you please have a look here? |
Contributor
|
This PR has been automatically marked as stale because it has been open 30 days |
Author
|
Bump. Anyone to review a tiny improvement please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small improvement for PrivateLink Access Blueprint
delete_enilambda function.It makes sure that the script exits early if no unhealthy targets found to de-register. That's unnecessary to fetch ENI and compare IPs with empty list of unhealthy targets.
Motivation and Context
A bit less execution time and reduce unnecessary API calls.
How was this change tested?
pre-commit run -awith this PR